openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/openerp-mgmtsystem/openupgrade70 into lp:openerp-mgmtsystem

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Sun, 16 Feb 2014 09:45:06 -0000
In-reply-to: <20131025165623.22195.68015.launchpad@ackee.canonical.com>
Reply-to: mp+192730@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

While you make the method to generate the legacy column name available without OpenUpgrade, you should check if the column exists around l.411. If the database is migrated otherwise, there will be no such column.

What is the use of checking if the openupgrade import is available if you define the functions yourself anyway as a fallback?

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-mgmtsystem/openupgrade70/+merge/192730
Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~savoirfairelinux-openerp/openerp-mgmtsystem/openupgrade70 into lp:openerp-mgmtsystem.