openerp-community-reviewer team mailing list archive

["Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review

Romain,

- lines seem a bit long to the naked eye
- you could catch only the exception you want to catch + a comment saying why you return False (i.e. "group does not exist)

thanks!
-- 
https://code.launchpad.net/~camptocamp/sale-reports/7.0-conditional_discount_print-rde/+merge/206678
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:sale-reports.