openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi into lp:purchase-wkfl

To: mp+206934@xxxxxxxxxxxxxxxxxx
From: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
Date: Tue, 18 Feb 2014 14:03:10 -0000
In-reply-to: <20140218134823.22514.15750.launchpad@ackee.canonical.com>
Reply-to: mp+206934@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review

LGTM.

Out of curiosity (I approve in any case) why do you actually need the trigger on the purchase line itself? in theory, purchase_id should not change.
-- 
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi/+merge/206934
Your team Purchase Core Editors is requested to review the proposed merge of lp:~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi into lp:purchase-wkfl.

References

[Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi into lp:purchase-wkfl
From: Nicolas Bessi - Camptocamp, 2014-02-18