openerp-community-reviewer team mailing list archive

["Sylvain LE GAL \(GRAP\)" <sylvain.legal@xxxxxxxxx>]

Sylvain LE GAL (GRAP) has proposed merging lp:~sylvain-legal/web-addons/web_export_view__fix_1271719 into lp:web-addons.

Commit message:
[FIX] 'web_export_view' : now export only selected items.

Requested reviews:
  Web-Addons Core Editors (webaddons-core-editors)
Related bugs:
  Bug #1271719 in Web addons for OpenERP: "Export all rows, only export rows selected"
  https://bugs.launchpad.net/web-addons/+bug/1271719

For more details, see:
https://code.launchpad.net/~sylvain-legal/web-addons/web_export_view__fix_1271719/+merge/207017

[FIX] now export only selected items.

Thanks to Carlos Lopez for suggesting fix code.
-- 
https://code.launchpad.net/~sylvain-legal/web-addons/web_export_view__fix_1271719/+merge/207017
Your team Web-Addons Core Editors is requested to review the proposed merge of lp:~sylvain-legal/web-addons/web_export_view__fix_1271719 into lp:web-addons.

=== modified file 'web_export_view/static/js/web_advanced_export.js'
--- web_export_view/static/js/web_advanced_export.js	2013-08-05 14:50:12 +0000
+++ web_export_view/static/js/web_advanced_export.js	2014-02-18 19:22:42 +0000
@@ -68,7 +68,7 @@
                 if($row.attr('data-id')){
                     export_row = [];
                     checked = $row.find('th input[type=checkbox]').attr("checked");
-                    if (children || checked === "checked"){
+                    if (children && checked === "checked"){
                         $.each(export_columns_keys,function(){
                             cell = $row.find('td[data-field="'+this+'"]').get(0);
                             text = cell.text || cell.textContent || cell.innerHTML || "";