openerp-community-reviewer team mailing list archive

[Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>]

Stéphane Bidoul (Acsone) has proposed merging lp:~sbi/ocb-addons/7.0-bug-1281579-sbi into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1281579 in OpenERP Community Backports (Addons): "Broken yml test in account_payment account_financial_report_webkit"
  https://bugs.launchpad.net/ocb-addons/+bug/1281579

For more details, see:
https://code.launchpad.net/~sbi/ocb-addons/7.0-bug-1281579-sbi/+merge/207378

Automatically derived from https://code.launchpad.net/~acsone-openerp/openobject-addons/7.0-bug-1281579-sbi for https://code.launchpad.net/~openerp/openobject-addons/7.0. Below is a copy of the original description.

In the account module demo data, the periods have all the special flag set to True, which is not a normal configuration for fiscal periods. In addition, there is no real opening period.

The present MP creates a proper opening period and set the special flag to False in all other periods in demo data.

This branch is green on runbot.
-- 
https://code.launchpad.net/~sbi/ocb-addons/7.0-bug-1281579-sbi/+merge/207378
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~sbi/ocb-addons/7.0-bug-1281579-sbi into lp:ocb-addons.

=== modified file 'account/demo/account_demo.xml'
--- account/demo/account_demo.xml	2012-10-23 16:05:04 +0000
+++ account/demo/account_demo.xml	2014-02-20 09:53:39 +0000
@@ -18,10 +18,19 @@
         Fiscal Periods
         -->    
         
+        <record id="period_0" model="account.period">
+            <field eval="'00/'+time.strftime('%Y')" name="code"/>
+            <field eval="'X 00/'+time.strftime('%Y')" name="name"/>
+            <field eval="True" name="special"/>
+            <field name="fiscalyear_id" ref="data_fiscalyear"/>
+            <field eval="time.strftime('%Y')+'-01-01'" name="date_start"/>
+            <field eval="time.strftime('%Y')+'-01-01'" name="date_stop"/>
+            <field name="company_id" ref="base.main_company"/>
+        </record>
         <record id="period_1" model="account.period">
             <field eval="'01/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 01/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-01-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-01-31'" name="date_stop"/>
@@ -30,7 +39,7 @@
         <record id="period_2" model="account.period">
             <field eval="'02/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 02/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-02-01'" name="date_start"/>
             <!-- for the last day of February, we have to compute the day before March 1st -->
@@ -40,7 +49,7 @@
         <record id="period_3" model="account.period">
             <field eval="'03/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 03/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-03-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-03-31'" name="date_stop"/>
@@ -49,7 +58,7 @@
         <record id="period_4" model="account.period">
             <field eval="'04/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 04/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-04-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-04-30'" name="date_stop"/>
@@ -58,7 +67,7 @@
         <record id="period_5" model="account.period">
             <field eval="'05/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 05/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-05-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-05-31'" name="date_stop"/>
@@ -68,7 +77,7 @@
             <field eval="'06/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 06/'+time.strftime('%Y')" name="name"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field eval="time.strftime('%Y')+'-06-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-06-30'" name="date_stop"/>
             <field name="company_id" ref="base.main_company"/>
@@ -76,7 +85,7 @@
         <record id="period_7" model="account.period">
             <field eval="'07/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 07/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-07-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-07-31'" name="date_stop"/>
@@ -85,7 +94,7 @@
         <record id="period_8" model="account.period">
             <field eval="'08/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 08/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-08-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-08-31'" name="date_stop"/>
@@ -94,7 +103,7 @@
         <record id="period_9" model="account.period">
             <field eval="'09/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 09/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-09-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-09-30'" name="date_stop"/>
@@ -103,7 +112,7 @@
         <record id="period_10" model="account.period">
             <field eval="'10/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 10/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-10-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-10-31'" name="date_stop"/>
@@ -112,7 +121,7 @@
         <record id="period_11" model="account.period">
             <field eval="'11/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 11/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-11-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-11-30'" name="date_stop"/>
@@ -121,7 +130,7 @@
         <record id="period_12" model="account.period">
             <field eval="'12/'+time.strftime('%Y')" name="code"/>
             <field eval="'X 12/'+time.strftime('%Y')" name="name"/>
-            <field eval="True" name="special"/>
+            <field eval="False" name="special"/>
             <field name="fiscalyear_id" ref="data_fiscalyear"/>
             <field eval="time.strftime('%Y')+'-12-01'" name="date_start"/>
             <field eval="time.strftime('%Y')+'-12-31'" name="date_stop"/>