openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_passport_passport_partner into lp:partner-contact-management

To: "El Hadji Dem \(http://www.savoirfairelinux.com\)" <elhadji.dem@xxxxxxxxxxxxxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Fri, 21 Feb 2014 13:51:21 -0000
In-reply-to: <20140130173209.11423.93121.launchpad@ackee.canonical.com>
Reply-to: mp+204033@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Hello El Hadji Dem

Thanks for your contrib.

At line 952-956 of this MP
<footer attrs="{'invisible': [('partner_id','=',False)]}">

Discard button is not available if invisible partner_id field is not set?


Could you explain why you need to add a create button instead of using the default one of one2many list?
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_passport_passport_partner/+merge/204033
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.

References

[Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_passport_passport_partner into lp:partner-contact-management
From: elhadji.dem@xxxxxxxxxxxxxxxxxxxx, 2014-01-30