openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Information

Code looks good to me, and it's working fine. It looks to me like a very specific use case, which also does not apply to Dutch accounting habits but it may be broader than just Spanish (you never know, right?) so I think having the module here is fine.

What bothers me a little is the module name. Yes, it extends the search but it does so in a very specific way. Would you consider to change the name to something like "account_account_wildcard_zero_search"?


-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.