openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~pedro.baeza/ocb-addons/7.0-bug-1173102 into lp:ocb-addons

To: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
From: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
Date: Mon, 24 Feb 2014 08:42:53 -0000
In-reply-to: <20140212083037.20021.57282.launchpad@ackee.canonical.com>
Reply-to: mp+205911@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information code review

This looks to me like someone calls _compute with the wrong precision. I think http://bazaar.launchpad.net/~ocb/ocb-addons/7.0/view/head:/account/account.py#L2189 is the culprit. Shouldn't we rather fix it there instead of ignoring the precision we get passed in _compute?
-- 
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-bug-1173102/+merge/205911
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.

References

[Merge] lp:~pedro.baeza/ocb-addons/7.0-bug-1173102 into lp:ocb-addons
From: Pedro Manuel Baeza, 2014-02-12