openerp-community-reviewer team mailing list archive

["Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>]

Review: Needs Fixing code review

#38 ... when selecting [what?] that ...
#89ff wouldn't the code be more clear if you did

my_new_partner_id = None
if partner_id:
  my_new_partner_id = 

result = super(my_new_partner_id or partner_id)

if my_new_partner_id != partner_id:
  result[value]['partner_id'] = my_new_partner_id
?

It took me a while to convince myself that the current implementation can't run into recursion problems
-- 
https://code.launchpad.net/~therp-nl/account-invoicing/7.0-add_account_invoice_partner/+merge/180694
Your team Account Core Editors is subscribed to branch lp:account-invoicing.