openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #04031
Re: [Merge] lp:~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr into lp:account-invoicing
Review: Approve code review
Good!
One small remark: why is the function _all_invoice_tax_line_computed not in the invoice class?
To show that it does not use any class or instance data, we can make it a @staticmethod.
I do not consider this a significant problem though, so I approve in any case.
Thanks
--
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr/+merge/201598
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
References