← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-post-deleted-move-lep into lp:account-financial-tools

 

Review: Approve code review

> Well, it's not the usual case, but it can be. BTW, I think this is a
> workaround. The real fix would be to patch button_validate method to bypass
> non existing records, don't you think?
> 
> Regards.

The Leonardo's fix is correct. The move may no longer exist at the time the job is executed so it has to ensure it still exists.
-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-post-deleted-move-lep/+merge/208360
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.


References