openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Review: Needs Information code review, no test

Can I suggest using the "value if condition else other_value" construct rather than "condition and value or other_value" 

the former is more explicit and does not suffer from the possible unintended behavior you get when value is False (you get other_value in that case even if condition is True). 
-- 
https://code.launchpad.net/~elicoidal/purchase-wkfl/purchase-wkfl-fix-0001/+merge/208758
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.