openerp-community-reviewer team mailing list archive

["Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>]

Holger Brunn (Therp) has proposed merging lp:~therp-nl/server-env-tools/6.1-fix-missing-subject into lp:server-env-tools/6.1.

Requested reviews:
  Server Environment And Tools Core Editors (server-env-tools-core-editors)
Related bugs:
  Bug #1286101 in Server Environment And Tools: "[fetchmail_attach_from_folder] IntegrityError: null value in column "subject" violates not-null constraint"
  https://bugs.launchpad.net/server-env-tools/+bug/1286101

For more details, see:
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-fix-missing-subject/+merge/208786
-- 
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-fix-missing-subject/+merge/208786
Your team Server Environment And Tools Core Editors is requested to review the proposed merge of lp:~therp-nl/server-env-tools/6.1-fix-missing-subject into lp:server-env-tools/6.1.

=== modified file 'fetchmail_attach_from_folder/model/fetchmail_server.py'
--- fetchmail_attach_from_folder/model/fetchmail_server.py	2013-05-01 06:22:51 +0000
+++ fetchmail_attach_from_folder/model/fetchmail_server.py	2014-02-28 12:27:47 +0000
@@ -209,7 +209,7 @@
                             'res_id': object_id,
                             'body_text': mail_message.get('body'),
                             'body_html': mail_message.get('body_html'),
-                            'subject': mail_message.get('subject'),
+                            'subject': mail_message.get('subject') or '',
                             'email_to': mail_message.get('to'),
                             'email_from': mail_message.get('from'),
                             'email_cc': mail_message.get('cc'),