openerp-community-reviewer team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code review, test, unittests

I ran the tests and, though I am not getting the problems with edi, there are still a few issues:

l.472,481 Test to fails in non English environments (try with lang = fr_FR)
This can be avoided by adding this
context = self.registry('res.users').context_get(self.cr, self.uid)
and using:
vals['name'] == (_('%s (copy)') % 'lastname') + " firstname"
vals['lastname'] == _('%s (copy)') % 'lastname'

On a side note, the assert equals could be done in a more elegant way. The error output I got was not very useful (AssertionError: False != True) since you're using asserts of the form: self.assertEqual(x == y and a == b, True).
This could be much better to separate it into multiple assertEquals (because what you have is basically an assertTrue):
self.assertEqual(x, y)
self.assertEqual(a, b)
Can you please fix this, it would make my debugging much simpler.
-- 
https://code.launchpad.net/~acsone-openerp/partner-contact-management/7.0-partner-firstname/+merge/202713
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.