openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Disapprove

> I think there's no side effect on the expression. It's also used everywhere on
> OpenERP core.
> 
> Regards.

Being used everywhere on OpenERP is not a good rationale.

Eric, the changes on the lines 9 and 27 of the diff are not correct: `prod_obj._choose_exp_account_from` expects a browse_record.

I proposed a correct fix [0] hence I reject this patch.

Thanks anyway

[0] https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-browse_record_error-1287159/+merge/209056
-- 
https://code.launchpad.net/~elicoidal/purchase-wkfl/purchase-wkfl-fix-0001/+merge/208758
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.