← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/purchase-wkfl/7.0-browse_record_error-1287159 into lp:purchase-wkfl

To: mp+209056@xxxxxxxxxxxxxxxxxx
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Mon, 03 Mar 2014 13:38:59 -0000
In-reply-to: <20140303123923.17257.17421.launchpad@ackee.canonical.com>
Reply-to: mp+209056@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Could fiscal_position be renamed fiscal_position_id?

BTW
fiscal_position_id = po.fiscal_position.id

Would also be valid as browse_null.id would return False
-- 
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-browse_record_error-1287159/+merge/209056
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

References

[Merge] lp:~camptocamp/purchase-wkfl/7.0-browse_record_error-1287159 into lp:purchase-wkfl
From: Guewen Baconnier @ Camptocamp, 2014-03-03