openerp-community-reviewer team mailing list archive

[Georges Racinet <gracinet@xxxxxxxxx>]

Hi Holger, thanks for the review.

Yes you're right: I thought that tools.file_open did some normalization on '/' (similar to an URL) to do its magic lookup in the wanted addons directory, but after re-reading its code, I see it does not, and indeed expects the incoming ``name`` argument to be built with os.sep, as in:

    if name.replace(os.sep, '/').startswith('addons/'):
        subdir = 'addons'
        name2 = name[7:]

That's probably because it also accepts absolute paths.

btw, I don't know of any platform where os.sep is more than 1 char, but the above extract would be wrong on it.


-- 
https://code.launchpad.net/~anybox/ocb-server/7.0-test-report/+merge/207978
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server.