openerp-community-reviewer team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Approve code review

LGTM, looking forward to using this module.

Note about the EDI unittests failures:

The function edi_import won't copy the name contents due to it being a function field, therefore lastname, being required, won't get autofilled from name.

A quick fix for this was to edit
addons/edi/models/res_partner.py:76
replace edi_document with dict(edi_document, lastname=edi_document.get('name'))
-- 
https://code.launchpad.net/~acsone-openerp/partner-contact-management/7.0-partner-firstname/+merge/202713
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.