openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Needs Fixing

The size argument could be entirely removed, it is no longer required since the version 7.0.
It should be used when there is a reason to restrict the length of a field (e.g. ean13), there is no reason to do so here (varchar and text are the same thing under the hood, so the limitation won't bring better performance [0]). 

For the record, here is the MP on the OpenERP's branch:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1079548-sgo/+merge/137482

Thanks

[0] http://stackoverflow.com/questions/4848964/postgresql-difference-between-text-and-varchar-character-varying
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209890
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.