openerp-community-reviewer team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Approve code review + tests

Hi,

I just checked that path and it work perfectly. I had the trouble in editing the email template, when you search for a field and ask for "search more..." you get this crash :

Server Traceback (most recent call last):
  File "/srv/openerp/instances/openerp_test_qoqa/parts/webclient/addons/web/session.py", line 89, in send
    return openerp.netsvc.dispatch_rpc(service_name, method, args)
  File "/srv/openerp/instances/openerp_test_qoqa/parts/server/openerp/netsvc.py", line 292, in dispatch_rpc
    result = ExportService.getService(service_name).dispatch(method, params)
  File "/srv/openerp/instances/openerp_test_qoqa/parts/server/openerp/service/web_services.py", line 626, in dispatch
    res = fn(db, uid, *params)
  File "/srv/openerp/instances/openerp_test_qoqa/parts/server/openerp/osv/osv.py", line 190, in execute_kw
    return self.execute(db, uid, obj, method, *args, **kw or {})
  File "/srv/openerp/instances/openerp_test_qoqa/parts/server/openerp/osv/osv.py", line 132, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/srv/openerp/instances/openerp_test_qoqa/parts/server/openerp/osv/osv.py", line 199, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/srv/openerp/instances/openerp_test_qoqa/parts/server/openerp/osv/osv.py", line 187, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/srv/openerp/instances/openerp_test_qoqa/parts/server-env-tools/mass_editing/mass_editing.py", line 34, in search
    model_domain += [('model_id', 'in', map(int, domain[2][1:-1].split(',')))]
TypeError: 'int' object has no attribute '__getitem__'

I confirm that this patch fix the issue.

Thanks !

-- 
https://code.launchpad.net/~rruebner/server-env-tools/7.0_fix_mass_editing/+merge/204711
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.