openerp-community-reviewer team mailing list archive

["Sylvain LE GAL \(GRAP\)" <sylvain.legal@xxxxxxxxx>]

Review: Needs Fixing code review, test

Hi, 

Thanks for your MP.

2 little thinks : 
1/ maybe it could be great to rename the module with the type of the field. Something like : 'web_many2one_polymorphic'. 

2/ I tested your code with the mail_organizer module available on lp.

In this module,if new_model is 'none' and I click to select a new ressource, it's raise an Error. Maybe the widget have to manage this case.
  
Log below : 

Traceback (most recent call last):
  File "~/ocb-server/openerp/netsvc.py", line 292, in dispatch_rpc
    result = ExportService.getService(service_name).dispatch(method, params)
  File "~/ocb-server/openerp/service/web_services.py", line 626, in dispatch
    res = fn(db, uid, *params)
  File "~/ocb-server/openerp/osv/osv.py", line 190, in execute_kw
    return self.execute(db, uid, obj, method, *args, **kw or {})
  File "~/ocb-server/openerp/osv/osv.py", line 132, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "~/ocb-server/openerp/osv/osv.py", line 199, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "~/ocb-server/openerp/osv/osv.py", line 186, in execute_cr
    raise except_osv('Object Error', 'Object %s doesn\'t exist' % str(obj))

Regards.

-- 
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is requested to review the proposed merge of lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons.