openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1192115 in OpenERP Community Backports (Addons): "[trunk/7.0] carrier information not propagated from sale order to pickings"
  https://bugs.launchpad.net/ocb-addons/+bug/1192115

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264

[FIX] delivery: carrier information not propagated from sale order to pickings.

port of https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-595240-opw-skh/+merge/180790 to OCB
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into lp:ocb-addons.

=== modified file 'delivery/sale.py'
--- delivery/sale.py	2012-10-23 16:05:04 +0000
+++ delivery/sale.py	2014-03-17 08:38:11 +0000
@@ -72,8 +72,7 @@
                 'tax_id': [(6,0,taxes_ids)],
                 'type': 'make_to_stock'
             })
-        #remove the value of the carrier_id field on the sale order
-        return self.write(cr, uid, ids, {'carrier_id': False}, context=context)
+        return True
         #return {'type': 'ir.actions.act_window_close'} action reload?
 
 sale_order()