openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server

To: "Cedric Le Brouster\(OpenFire\)" <cedric.lebrouster@xxxxxxxxxxx>
From: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
Date: Mon, 17 Mar 2014 08:48:55 -0000
In-reply-to: <20140306144121.2904.91904.launchpad@ackee.canonical.com>
Reply-to: mp+209708@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review

This patch looks a bit scary at first, mainly because you have to read it closely to convince yourself that it doesn't trigger a recomputation on every write().

#123-133 can be done in one SQL statement I think, given that we touch that code anyway such an optimization wouldn't hurt imho.
-- 
https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order/+merge/209708
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server.

References

[Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server
From: Cedric Le Brouster(OpenFire), 2014-03-06