openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server

To: Leonardo Pistone - camptocamp <leonardo.pistone@xxxxxxxxxxxxxx>
From: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 17 Mar 2014 14:25:13 -0000
In-reply-to: <20140317114032.4476.62421.launchpad@ackee.canonical.com>
Reply-to: mp+211290@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

I disagree with taking out .swp files.
Having .swp in the ignore file means that we would never want that kind of file tracked.
I suggest using a different method to track swp files such as:
bzr ignored | grep .swp
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-leaner-bzrignore-lep/+merge/211290
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server.

References

[Merge] lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server
From: Leonardo Pistone - camptocamp, 2014-03-17