openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

quite a lot a code, and no test... :-(

Remarks:

* line 353 (in compute_delay_from_partial_rec): it would be nicer to move reference_line = line in the else clause of the if / elif statement (makes it clear that reference_line has avalue in all cases)

* line 381 and 383 (in get_compute_method) are the same. Can they be merged in the same branch?

* line 452: avoid the call to float() unless you have string in total[drange]. If you want to protect against int / int -> int, add from __future__ import division at the beginning of the module (and use // for integer division). 

* line 472 and following (in get_reconcile_count_lookup): don't add \n in SQL statement. 

* line 477 and following (in get_reconcile_count_lookup): the "if res"  is useless, as well as the return {}. 


-- 
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.