openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

To: mp+193717@xxxxxxxxxxxxxxxxxx
From: Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>
Date: Tue, 18 Mar 2014 10:52:32 -0000
In-reply-to: <20131103205723.19672.9022.launchpad@ackee.canonical.com>
Reply-to: mp+193717@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Hello,  

The parameter/fallback solution seems reasonable assuming that period parameter is not mandatory.
For me you can update the MP with that solution.

Also as the change will alter data structure the revision number of the module must be increased in MP.

I'm putting the MP in work in progress while waiting new patch.

Thanks for the work.

Regards

Nicolas


-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.

References

lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report
From: Luc De Meyer (Noviat), 2013-11-03