openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #05237
Re: [Merge] lp:~camptocamp/lp-community-utils/nag-user-specific-info into lp:lp-community-utils
Review: Needs Fixing code review, pep8
Looks, good, just a few pep8 issues:
openerp-nag:72:9: E126 continuation line over-indented for hanging indent
MY_READY: "My MPs ready to land",
^
openerp-nag:73:9: E126 continuation line over-indented for hanging indent
MY_PENDING: "My MPs needing some love",
^
openerp-nag:74:9: E126 continuation line over-indented for hanging indent
REVIEWED_READY: "Ready to land, please Merge us!",
^
openerp-nag:75:9: E126 continuation line over-indented for hanging indent
REVIEWED_UPDATED: "To check, updated since last need fixing vote",
^
openerp-nag:76:9: E126 continuation line over-indented for hanging indent
REVIEWED_PENDING: "Nothing to do I've already reviewed those",
^
openerp-nag:77:9: E126 continuation line over-indented for hanging indent
NOT_REVIEWED: "I didn't reviewed those ones",
^
openerp-nag:80:1: E302 expected 2 blank lines, found 1
def show_lp_object(obj):
^
^
openerp-nag:390:5: E303 too many blank lines (2)
if args.triage:
^
openerp-nag:415:5: E303 too many blank lines (2)
print('Votes legend:')
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils.
References