openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools

To: Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Sun, 23 Mar 2014 19:06:18 -0000
In-reply-to: <20131107105928.10262.75037.launchpad@ackee.canonical.com>
Reply-to: mp+194315@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

If I understand correctly, this change creates an implicit dependency on portal. While this module is set to autoinstall, we often disable it on our setups. Maybe it would be a slightly less ugly workaround to add the tab with the lines of this particular model in a separate view definition with group_ids set to the manager group?

-- 
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906/+merge/194315
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.

References

lp:~acsone-openerp/account-financial-tools/account_credit_control_portal_portal_lp1248906 into lp:account-financial-tools
From: Acsone, 2013-11-07