openerp-community-reviewer team mailing list archive

[Alexis de Lattre <alexis@xxxxxxxxxx>]

I see that this module got merged without modification, and none of the points that I raise in my review were addressed, which is a bit surprising.

For example, the point 3 that I raised was :
<<
on the invoice line, you add a field 'displayed_lot_id' but you don't use it anywhere. What is this field for ?
>>

Lorenzo answered that this field was useless and could be removed. But the module was commited to the branch with this field. So we have a just added a module with a field that nobody knows what it is for.

Joël, why did you commit the module without changes ? We could have at least cleaned-up this !


-- 
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report.