openerp-community-reviewer team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Sorry I have to withdraw my approve,

After proofreading the credit communication code I can not accept you patch.

A credit communication is an aggregation of credit lines per partner per policy level.

That means related credit lines can be related to many invoices that have the same level of overdue.

So the way to determine the invoice is not correct, also you should use the communication partner_id address not the one of the invoice. The adress is deternined using the function get_contact_address that will return the invoice address first if available.

Also it is possible to have credit line without invoices so you have to manage this usecase.


Regards

Nicolas



-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/credit_control_report_improvement_vre/+merge/201920
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.