openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt

To: mp+212299@xxxxxxxxxxxxxxxxxx
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Tue, 25 Mar 2014 13:10:19 -0000
In-reply-to: <20140322202622.28687.6280.launchpad@ackee.canonical.com>
Reply-to: mp+212299@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information code review

Hi, Jordi,

Thanks for the contribution. Some questions about your MP:

- Why do you need _get_department method? If you put a related field, this method is not needed.
- Is it possible that you link a different department for the same account_id? If it's so, related field is not the best approach.

Regards.
-- 
https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic/+merge/212299
Your team Department Core Editors is subscribed to branch lp:department-mgmt.

References

[Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt
From: JB (eficent.com), 2014-03-22