openerp-community-reviewer team mailing list archive

[Paul Catinean <paul.catinean@xxxxxxxxx>]

Paul Catinean has proposed merging lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1244183 in OpenERP Community Backports (Addons): "Deleting boms does not delete subproducts (Byproduct Module) ?"
  https://bugs.launchpad.net/ocb-addons/+bug/1244183

For more details, see:
https://code.launchpad.net/~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink/+merge/213086

Port to OCB of the following fix:

[FIX] Added ondelete='cascade' to mrp.subproduct when attatched bom is unlinked

https://code.launchpad.net/~wiz-keed/openobject-addons/7.0-fix-mrp-subproduct-unlink/+merge/213078
-- 
https://code.launchpad.net/~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink/+merge/213086
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink into lp:ocb-addons.

=== modified file 'mrp_byproduct/mrp_byproduct.py'
--- mrp_byproduct/mrp_byproduct.py	2014-03-10 08:54:20 +0000
+++ mrp_byproduct/mrp_byproduct.py	2014-03-27 15:10:01 +0000
@@ -35,7 +35,7 @@
   'Fixed' depicts a situation where the quantity of created byproduct is always equal to the quantity set on the BoM, regardless of how many are created in the production order.\
   By opposition, 'Variable' means that the quantity will be computed as\
     '(quantity of byproduct set on the BoM / quantity of manufactured product set on the BoM * quantity of manufactured product in the production order.)'"),
-        'bom_id': fields.many2one('mrp.bom', 'BoM'),
+        'bom_id': fields.many2one('mrp.bom', 'BoM', ondelete='cascade'),
     }
     _defaults={
         'subproduct_type': 'variable',