openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Rising my Needs Fixing flag, I won't approve for the merge until the portal module is removed from the dependencies.
There is no point to force the installation of the portal in order to merge partners.
The message added in base_partner_merge/wizard/portal_wizard.py does not worth the dependency IMO, and even if it had value it could be done in a third - auto_install - module.
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.