← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description into lp:partner-contact-management

 

Review: Needs Fixing code review, no tests

Hi Mathieu,

Thanks for your contribution.

Here's my review:

l.172 Please use orm instead of osv.
l.175 osv.Model -> orm.Model
l.192 It's not a good idea to override a view's external id. Please pick another name for the id. 
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner_category_description/+merge/212507
Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description into lp:partner-contact-management.


References