openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

Hello,

Thanks for this proposal. Here are few things to fix.


In _compute_name_custom why not using the same way to construct the full name?

http://bazaar.launchpad.net/~partner-contact-core-editors/partner-contact-management/7.0/view/head:/partner_firstname/partner.py#L43



ir.model.data is defined twice.

128	+        obj_data = self.pool.get('ir.model.data')
129	+        ## We search category for this contact :
130	+        obj_data = self.pool.get('ir.model.data')
131	+        ##

By the way you can use list index

self.pool['ir.model.data']



crm.py|111 col 1| F841 local variable 'create_context' is assigned to but never used


ll.133 - 139 missing context in search and browse
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.