openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

I fail to see how the addon name "crm_firstname" relates to the described functionality. Please copy the description provided in the MP in __openerp__.py : this is what people looking at the module will see. 

__openerp__.py : s/demo_xml/demo/ and then remove it as it is empty

+ 'email': tools.email_split(lead.email_from) and tools.email_split(lead.email_from)[0] or False, => use the val if cond else default construct if you absolutely want this on a single line. Same thing for the other fields in that dict. 

you forgot to add the tests and to link them in __openerp__.py :-)
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.