openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

To: mp+205212@xxxxxxxxxxxxxxxxxx
From: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Wed, 02 Apr 2014 14:23:07 -0000
In-reply-to: <20140206163422.8973.21623.launchpad@ackee.canonical.com>
Reply-to: mp+205212@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

42	+ 'account.hours.block': (lambda self, cr, uid, ids, c=None:
43	+ ids, ['invoice_id'], 10),

this is a very bad line split, please keep the 'ids' on the same line as the lambda


missing i18n update
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management.

References

[Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management
From: Matthieu Dietrich @ camptocamp, 2014-02-06