openerp-community-reviewer team mailing list archive

[Romain Deheele - Camptocamp <romain.deheele@xxxxxxxxxxxxxx>]

Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)
Related bugs:
  Bug #1301458 in Carriers And Deliveries Management: "[6.1/7.0] possible error : TypeError: 'must be type, not browse_record'"
  https://bugs.launchpad.net/carriers-deliveries/+bug/1301458

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881

Hi,

In base_delivery_carrier_files_document, file carrier_file.py,
by coincidence, the class and a frequently used parameter are both named "carrier_file".
in l.61, the super method will take carrier_file parameter while it needs carrier_file, the class name.
It causes logically the error : TypeError: 'must be type, not browse_record'

Great catch from Leonardo Pistone, thank you.

Regards,

Romain
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries.

=== modified file 'base_delivery_carrier_files_document/carrier_file.py'
--- base_delivery_carrier_files_document/carrier_file.py	2014-03-27 14:49:41 +0000
+++ base_delivery_carrier_files_document/carrier_file.py	2014-04-02 15:58:23 +0000
@@ -24,11 +24,11 @@
 from openerp.osv import orm, fields
 
 
-class carrier_file(orm.Model):
+class carrier_file_model(orm.Model):
     _inherit = 'delivery.carrier.file'
 
     def get_write_mode_selection(self, cr, uid, context=None):
-        res = super(carrier_file, self).\
+        res = super(carrier_file_model, self).\
             get_write_mode_selection(cr, uid, context=context)
         if 'document' not in res:
             res.append(('document', 'Document'))
@@ -58,6 +58,6 @@
             self.pool['ir.attachment'].create(cr, uid, vals, context=context)
             return True
         else:
-            return (super(carrier_file, self)
+            return (super(carrier_file_model, self)
                     ._write_file(cr, uid, carrier_file, filename, file_content,
                                  context=None))