openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review

Hi, Yannick, several things:

- Instead of replacing a field, it's better to put position="attributes" and only overwrite attribute on_change, so that you don't replace another attributes of the field.

- I think it's better to use module web_context_tunnel to avoid changes on the signature of the method that provokes incompatibilities between modules.

Regards.
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058
Your team Sale Core Editors is subscribed to branch lp:sale-financial.