openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Information

Thanks for your changes. Code looks good now.

One thing I missed earlier, did you allow for carriers with a company one level up from the user's company on purpose? This is encoded in the clause ('company_id.child_ids','child_of',[user.company_id.id]). It is more common not to do so, except for products and documents.

-- 
https://code.launchpad.net/~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness/+merge/214176
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.