openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Thanks for the response! It's not so much more flexible as simply more accessible. But then, sharing carriers between the parent company and its children is not as problematic as sharing accounting move lines. So I agree with the current, broad rule.

Last couple of details:
- you'll want to set noupdate="1" for the rule as per OpenERP convention, and
- you can remove the assignment of 'global', which is a function field.

Following the policy of OCB, you created an accompanying proposal against upstream openobject-addons. However, you targetted openobject-addons/7.0 but you had better target trunk instead as this could well be regarded as a feature request by OpenERP SA (see https://bugs.launchpad.net/ocb-addons/+bug/1253701 for reference). The upstream proposal needs to be updated with the same changes as this branch, of course.

-- 
https://code.launchpad.net/~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness/+merge/214176
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.