openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Sun, 06 Apr 2014 08:48:09 -0000
In-reply-to: <20140325222528.6843.9273.launchpad@ackee.canonical.com>
Reply-to: mp+212736@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Thanks for the proposal!

Strings like 'AccessError' and 'ValidateError' are not proper English, so they cannot be translated. Either we accept the current strings as fixed codes (in lieu of a proper exception type) and they should not be passed to gettext, or we should replace them with translatable strings such as Access Error and Validation Error.

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server.

References

[Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server
From: Sandy Carter (http://www.savoirfairelinux.com), 2014-03-25