openerp-community-reviewer team mailing list archive

[Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>]

Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1291903 in OpenERP Community Backports (Addons): "[OCB] sale_stock: property_ids set on procurement.order"
  https://bugs.launchpad.net/ocb-addons/+bug/1291903

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls/+merge/214435

This reverts the fix for bug #1083077. It was fixed in OCB in the wrong module, and eventually fixed the right way in 7.0.
Incidentally this is the last change needed to make OCB run green on runbot : http://runbot.openerp.com/numerigraphe-team-7-0-revert-sale-properties-1291903-ls-runbot-32832/logs/
(Resubmitting because LP seems to have stalled the first time)
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls/+merge/214435
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls into lp:ocb-addons.

=== modified file 'sale_stock/sale_stock.py'
--- sale_stock/sale_stock.py	2014-03-24 09:12:54 +0000
+++ sale_stock/sale_stock.py	2014-04-06 12:52:19 +0000
@@ -303,7 +303,6 @@
                     or line.product_uom.id,
             'location_id': order.shop_id.warehouse_id.lot_stock_id.id,
             'procure_method': line.type,
-            'property_ids': [(6, 0, [l.id for l in line.property_ids])],
             'move_id': move_id,
             'company_id': order.company_id.id,
             'note': line.name,