openerp-community-reviewer team mailing list archive

["Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>]

Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1303829 in OpenERP Web: "Show more in a one2many kanban view does nothing"
  https://bugs.launchpad.net/openerp-web/+bug/1303829

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-web/lp1303829/+merge/214542
-- 
https://code.launchpad.net/~therp-nl/ocb-web/lp1303829/+merge/214542
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web.

=== modified file 'addons/web_kanban/static/src/js/kanban.js'
--- addons/web_kanban/static/src/js/kanban.js	2014-01-17 10:19:43 +0000
+++ addons/web_kanban/static/src/js/kanban.js	2014-04-07 14:03:24 +0000
@@ -637,12 +637,10 @@
     },
     do_show_more: function(evt) {
         var self = this;
-        var ids = self.view.dataset.ids.splice(0);
         return this.dataset.read_slice(this.view.fields_keys.concat(['__last_update']), {
             'limit': self.view.limit,
             'offset': self.dataset_offset += self.view.limit
         }).then(function(records) {
-            self.view.dataset.ids = ids.concat(self.dataset.ids);
             self.do_add_records(records);
             self.compute_cards_auto_height();
             self.view.postprocess_m2m_tags();