openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report

To: "Vincent Renaville@camptocamp" <vincent.renaville@xxxxxxxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Mon, 07 Apr 2014 16:19:18 -0000
In-reply-to: <20140403133549.31167.53477.launchpad@ackee.canonical.com>
Reply-to: mp+214030@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

Fixed previous 'need fixing'.

The change LGTM

As a side note, it seems there is an extra <tr> opening tag at lines 94, 109, 221 and 236 but this is unreleated to this MP thus I approve it.
-- 
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.

References

[Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report
From: Vincent Renaville@camptocamp, 2014-04-03