openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools.

Commit message:
[IMP] account_renumber: Spaces instead tabs on XML.
[FIX] account_renumber: Group restriction for the menu removed.

Requested reviews:
  Account Core Editors (account-core-editors)

For more details, see:
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832

[IMP] account_renumber: Spaces instead tabs on XML.
[FIX] account_renumber: Group restriction for the menu removed. This restriction to "Configuration" users doesn't make sense, because one accountant can renumber journal entries without belonging to this group.
-- 
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832
Your team Account Core Editors is requested to review the proposed merge of lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools.

=== modified file 'account_renumber/wizard/wizard_renumber_view.xml'
--- account_renumber/wizard/wizard_renumber_view.xml	2013-09-28 15:40:31 +0000
+++ account_renumber/wizard/wizard_renumber_view.xml	2014-04-08 20:06:45 +0000
@@ -1,48 +1,51 @@
 <?xml version="1.0" encoding="utf-8"?>
 <openerp>
-	<data>
-
-		<record id="view_account_renumber_form" model="ir.ui.view">
-			<field name="name">account_renumber.form</field>
-			<field name="model">wizard.renumber</field>
-			<field name="arch" type="xml">
-				<form string="Renumber Account Moves" version="7.0">
-					<field name="state" invisible="1" />
-					<p>This wizard will help you renumber entries in one or more journals.</p>
-					<p>Posted moves from those journals will be sorted by date and then assigned</p> 
-					<p>sequential numbers using their journal sequence.</p>
-					<group string="General Data">
-						<field name="number_next"/>
-					</group>
-					<group string="Journals and periods to consider">
-						<notebook colspan="4">
-							<page string="Journals">
-								<field name="journal_ids" editable="top"/>
-							</page>
-							<page string="Periods">
-								<field name="period_ids" editable="top"/>
-							</page>
-						</notebook>
-					</group>
-					<footer>
-						<div states="init">
-							<button name="renumber" string="Renumber" type="object" class="oe_highlight"/>o
-							<button special="cancel" string="Cancel" class="oe_link"/>
-						</div>
-					</footer>
-				</form>
-			</field>
-		</record>
-		<record id="action_account_renumber" model="ir.actions.act_window">
-			<field name="name">Renumber journal entries</field>
-			<field name="res_model">wizard.renumber</field>
-			<field name="view_type">form</field>
-			<field name="view_mode">form</field>
-			<field name="view_id" ref="view_account_renumber_form" />
-			<field name="target">new</field>
-		</record>
-		<menuitem id="menu_account_renumber" parent="account.menu_account_end_year_treatments"
-			action="action_account_renumber" groups="base.group_system" sequence="-1" />
-
-	</data>
+    <data>
+
+        <record id="view_account_renumber_form" model="ir.ui.view">
+            <field name="name">account_renumber.form</field>
+            <field name="model">wizard.renumber</field>
+            <field name="arch" type="xml">
+                <form string="Renumber Account Moves" version="7.0">
+                    <field name="state" invisible="1" />
+                    <p>This wizard will help you renumber entries in one or more journals.</p>
+                    <p>Posted moves from those journals will be sorted by date and then assigned</p>
+                    <p>sequential numbers using their journal sequence.</p>
+                    <group string="General Data">
+                        <field name="number_next"/>
+                    </group>
+                    <group string="Journals and periods to consider">
+                        <notebook colspan="4">
+                            <page string="Journals">
+                                <field name="journal_ids" editable="top"/>
+                            </page>
+                            <page string="Periods">
+                                <field name="period_ids" editable="top"/>
+                            </page>
+                        </notebook>
+                    </group>
+                    <footer>
+                        <div states="init">
+                            <button name="renumber" string="Renumber" type="object" class="oe_highlight"/>
+                            o
+                            <button special="cancel" string="Cancel" class="oe_link"/>
+                        </div>
+                    </footer>
+                </form>
+            </field>
+        </record>
+        <record id="action_account_renumber" model="ir.actions.act_window">
+            <field name="name">Renumber journal entries</field>
+            <field name="res_model">wizard.renumber</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">form</field>
+            <field name="view_id" ref="view_account_renumber_form" />
+            <field name="target">new</field>
+        </record>
+        <menuitem id="menu_account_renumber"
+                parent="account.menu_account_end_year_treatments"
+                action="action_account_renumber"
+                sequence="-1"/>
+
+    </data>
 </openerp>