openerp-community-reviewer team mailing list archive

[Yajo <yajo.sk8@xxxxxxxxx>]

Yajo has proposed merging lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools.

Requested reviews:
  Stefan Rijnhart (Therp) (stefan-therp)
Related bugs:
  Bug #1302547 in Server Environment And Tools: "[users_ldap_groups] Cannot login if "Only ldap groups" is checked"
  https://bugs.launchpad.net/server-env-tools/+bug/1302547

For more details, see:
https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214890

Fix bug #1302547.
-- 
https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214890
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.

=== modified file 'users_ldap_groups/users_ldap_groups.py'
--- users_ldap_groups/users_ldap_groups.py	2013-07-23 11:21:53 +0000
+++ users_ldap_groups/users_ldap_groups.py	2014-04-09 07:15:13 +0000
@@ -83,7 +83,7 @@
     conf_all=self.read(cr, uid, conf['id'], ['only_ldap_groups'])
     if(conf_all['only_ldap_groups']):
         logger.debug('deleting all groups from user %d' % user_id)
-        userobj.write(cr, uid, user_id, {'groups_id': [(5, )]})
+        userobj.write(cr, uid, [user_id], {'groups_id': [(5, )]})
 
     for mapping in mappingobj.read(cr, uid, mappingobj.search(cr, uid, 
             [('ldap_id', '=', conf['id'])]), []):
@@ -93,6 +93,6 @@
                 mapping['value'], conf, self, logger):
             logger.debug('adding user %d to group %s' % 
                     (user_id, mapping['group'][1]))
-            userobj.write(cr, uid, user_id, 
+            userobj.write(cr, uid, [user_id], 
                     {'groups_id': [(4, mapping['group'][0])]})
     return user_id