openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

To: Romain Deheele - Camptocamp <romain.deheele@xxxxxxxxxxxxxx>
From: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Fri, 11 Apr 2014 08:46:52 -0000
In-reply-to: <20140410131925.17884.61395.launchpad@ackee.canonical.com>
Reply-to: mp+214568@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

Needs fixing:

* convert the description in __openerp__.py to Restructured Text
* please add a test
* I'm concerned the SQL query may bypass the multicompany security rules
* NEVER DO SQL PARAMETER SUBSTITUTION WITH THE % OPERATOR!!!!


-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows.

References

[Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows
From: Romain Deheele - Camptocamp, 2014-04-10