openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #05897
Re: [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
Review: Needs Fixing
Nico,
line 74,76: I think you should use 'lot_icecream_0' and 'lot_icecream_1'
line 91: you are writing 'prodlot_id' field with another lot, but I think it's unnecessary, as lots are already assigned by 'stock.move.split' wizard.
line 115: the test is checking if the invoice lines are 2, but the bug said
"Now the 2 different serial number will be repeat for each invoice line, while each line must have only its serial"
So, the test should check if every invoice line has got only one lot
line 112: 'ac' is unnecessary
Thanks
--
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report.
References