openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/ocb-server/6.1-lp933496 into lp:ocb-server/6.1

To: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
From: Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>
Date: Sun, 13 Apr 2014 21:27:44 -0000
In-reply-to: <20131029080626.8735.52004.launchpad@ackee.canonical.com>
Reply-to: mp+193011@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

The patch can be further improved by using a TransientModel instead of a Model for testing. In v7.0 this fixes a warning about missing permissions. See http://bazaar.launchpad.net/~numerigraphe-team/ocb-server/7.0-po-targets-933496-vmt/revision/4798
I don't see any other problem than this detail, so I approve.
-- 
https://code.launchpad.net/~therp-nl/ocb-server/6.1-lp933496/+merge/193011
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server/6.1.

References

[Merge] lp:~therp-nl/ocb-server/6.1-lp933496 into lp:ocb-server/6.1
From: Holger Brunn (Therp), 2013-10-29